Fix session ID for automatic upload #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwatters01
approved these changes
Dec 18, 2023
|
@nwatters01 Also let me know if you want to modify this field in the already existing NWB files instead of reconverting them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic upload function automatically adjusts filename to always include session ID, which
dandi organizeonly does when there's more than one session per subject (which we hadn't previously seen in initially shared data)In this instance, it also depends on the uniqueness of the
data_dir_path, which we can't see on the entire MIT sideI can eventually fix the helper in NeuroConv around this condition, but for now this should fix it
Will have to consider if including
ses-innwbfile.session_idis against best practice or not... strictly speaking the DANDI convention is to name file as..._ses-{session_id}_...so it would be weird to also haveses-in the session ID itself (source of issue here)